Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Update Lighthouse book and some FAQs #4178

Closed
wants to merge 43 commits into from

Conversation

chong-he
Copy link
Member

Issue Addressed

Updated Lighthouse book on Section 2 and added some FAQs

Proposed Changes

All changes are made in the book/src .md files.

Additional Info

Please provide any additional information. For example, future considerations
or information useful for reviewers.

@michaelsproul michaelsproul self-requested a review April 11, 2023 23:54
@michaelsproul michaelsproul added the ready-for-review The code is ready for review label Apr 11, 2023
@michaelsproul michaelsproul added the waiting-on-author The reviewer has suggested changes and awaits thier implementation. label Apr 12, 2023
@chong-he
Copy link
Member Author

Thank you so much for the meticulous review! I will update them

Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

book/src/faq.md Outdated Show resolved Hide resolved
@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. v4.1.0 Post-Capella minor release and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Apr 14, 2023
@michaelsproul
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Apr 14, 2023
## Issue Addressed

Updated Lighthouse book on Section 2 and added some FAQs

## Proposed Changes

All changes are made in the book/src .md files.

## Additional Info

Please provide any additional information. For example, future considerations
or information useful for reviewers.


Co-authored-by: chonghe <[email protected]>
Co-authored-by: Michael Sproul <[email protected]>
@bors bors bot changed the title Update Lighthouse book and some FAQs [Merged by Bors] - Update Lighthouse book and some FAQs Apr 14, 2023
@bors bors bot closed this Apr 14, 2023
ghost pushed a commit to oone-world/lighthouse that referenced this pull request Jul 13, 2023
## Issue Addressed

Updated Lighthouse book on Section 2 and added some FAQs

## Proposed Changes

All changes are made in the book/src .md files.

## Additional Info

Please provide any additional information. For example, future considerations
or information useful for reviewers.


Co-authored-by: chonghe <[email protected]>
Co-authored-by: Michael Sproul <[email protected]>
@chong-he chong-he deleted the book-chap-2 branch December 3, 2023 09:39
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
## Issue Addressed

Updated Lighthouse book on Section 2 and added some FAQs

## Proposed Changes

All changes are made in the book/src .md files.

## Additional Info

Please provide any additional information. For example, future considerations
or information useful for reviewers.


Co-authored-by: chonghe <[email protected]>
Co-authored-by: Michael Sproul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation ready-for-merge This PR is ready to merge. v4.1.0 Post-Capella minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants